CharliePoole

Results 1009 comments of CharliePoole

I can confirm that this is how the adapter is written. There is never any filtering applied on test discovery. This makes sense given that it was written originally with...

Precisely. We would need to find out what parameter is being passed and how. Our relation to the MS code is that we find out how it works by running...

@jnm2 That's a little tacky to point out! 😸 The "initial upload" wasn't that initial. It was just copying the code that was already present from years back into a...

@OsirisTerje Re our email issues... I did get an email that you asked for my review of this.

It's a clever idea to use text conversion rather than parsing, changing the text representation of the VS filter to the text representation of an NUnit filter. It should work...

Of course, 3 was what I originally proposed to you. The impedance mismatch will always exist but some approaches make it easier than others to give a precise error message....

Sounds OK then.

This was intended as an issue for NUnit, not the adapter. I created nunit/nunit#1026 to track it. We'll use this issue to remind us to fix the adapter after NUnit...

For the sake of history, adding to the prior comments... With NUnit 3, I actually made a decision not to support trace directly, but to leave it up to the...

You're right. At the time, there was discussion, but it was transient and folks just coming into it now don't have any place to get that info. I don't think...