CatherineF-dev
CatherineF-dev
/remove-lifecycle stale
Ready for reviewing~
/hold I find it still has these newly added dependencies. Will try to remove these as well. ``` v2/pkg/customresourcestate ├──v2/pkg/metricshandler ├──v2/pkg/options ├──v2/internal/store ```
/unhold Current godepgraph is ``` v2/pkg/builder/types ├──v2/pkg/metric_generator ├──v2/pkg/options ├──v2/pkg/metrics_store └──v2/pkg/customresource v2/pkg/metric_generator └──v2/pkg/metric v2/pkg/options v2/tests/e2e/framework v2/pkg/builder ├──v2/pkg/builder/types ├──v2/pkg/metric_generator ├──v2/internal/store ├──v2/pkg/customresource ├──v2/pkg/metrics_store └──v2/pkg/options v2/pkg/customresource └──v2/pkg/metric_generator v2/pkg/customresourcestate ├──v2/pkg/metric ├──v2/pkg/metric_generator ├──v2/internal/discovery ├──v2/pkg/customresource └──v2/internal/store v2/pkg/watch...
Ping ~ @rexagod @mrueg
Reviewed internal/store/job.go. If you split this PR into two PRs (job and pv), I think the job one can be merged asap.
/lgtm Waiting @rexagod's review
A related https://github.com/kubernetes/kube-state-metrics/issues/1978 Current Custom State Resource API is a little complicated. Adding more features might bring more maintaining work and make it harder to migrate into cel. I think...
Reuse the wheel (cel, a query model) can reduce our maintaining work on how to extract fields. Then we can spend efforts on other things, instead of putting many efforts...