CatherineF-dev

Results 236 comments of CatherineF-dev

> Hey, thank you for working on this. Just a question right off the top of my mind, would this be better suited to be in a KSM _operator_? I...

Hi @dgrisonnet, could you help review this design doc when you're available? Thanks! Related issues https://github.com/kubernetes/kube-state-metrics/issues/2050 https://github.com/kubernetes/kube-state-metrics/issues/1948

Yes, from previous discussion, I remember we plan to split KSM and KSM Custom Metrics into 2 binaries first. Then add CRD feature. So I haven't resolved conflicts in this...

It should be related to https://github.com/kubernetes/kube-state-metrics/pull/1851 where adding PollForCacheUpdates function.

It deletes removed CR here https://github.com/rexagod/kube-state-metrics/blob/main/internal/discovery/discovery.go#L42C24-L116, while didn't delete removed CR here https://github.com/rexagod/kube-state-metrics/blob/25a1d8da057cf761d614c59a52785335d34082d1/internal/discovery/discovery.go#L232. How about creating a new issue and merging this PR as a mitigation? I think it needs...

> If there is an hpa object, which has two metrics with the same name but different selectors QQ: are these two metrics the same or different? In thinking whether...

Could you give a detailed example (CRD + CR) so that I can reproduce? You can change CRD / CR a little bit as long as it can be reproduced.

A related issue https://github.com/kubernetes/kube-state-metrics/issues/1978, so that you can use cel to extract what you want.

Thanks for reporting this issue, found you have already used v2.8.2 as a mitigation.