Greg comments

Results 7 comments of


                                            Greg

trafficstars

Prefer to obtain router directly from container, over the route

@mike-north This looks great. Tiny point, should you also update the package version?

Prefer to obtain router directly from container, over the route

@mike-north Yep, that seems fair. Although.....there doesn't seem to have been much action on that front for a while. It would be good to get these changes merged.

deprecation warning ember 3.9 - computed-property.volatile

This sounds like it's linked to: [#638](https://github.com/offirgolan/ember-cp-validations/issues/638)

Unique data-test-* row attributes for ember-test-selectors

I'm not sure I understand how to use the above information. As I understand it, a data-test-selector is for use in a test so that something can be selected in...

power select does not pass ember-a11y checks

I am using ember-power-select 3.0.2 with ember-a11y 0.2.1 on ember 3.11 and I get a lot of accessibility errors. ![Captura de Pantalla 2019-08-07 a la(s) 10 04 32 a m](https://user-images.githubusercontent.com/1338054/62722663-d08a5a00-b9c3-11e9-8752-b0f8eedeeebc.png)...

Hyphens are not supported in unquoted strings (key names)

Confirmed to work with latest! Thanks @walshie4

Question: How do I use this add-on to import a node package for use in a test?

Thanks for the prompt response. I tried `ember-browserify` but it didn't seem to work; after following the steps in their docs, it still wasn't able to find the module. I...