Ben Matase

Results 9 comments of Ben Matase

This would solve https://github.com/apt-itude/rules_pip/issues/46

I can do the work and try and fix this in this repo, but could use some pointers

@leodido it changed a lot in the .go file. Is this error output the reason? ``` [bmatase@bmatase-mbp go-syslog (fix-global-var-race)]$ make build ragel -I common -Z -G2 -e -o rfc5424/builder.go rfc5424/builder.go.rl...

I see the problem. Working on fixing it

@leodido had some trouble with the `-i` aka inplace flags on my mac but I think it is in good shape now

@leodido I believe I've addressed the changes you requested. Let me know if there is anything else you spot

Sorry, I hit the create button and it wasn't giving me feedback that it actually happened. I'll duplicate the others

I'm open to implementing this, just wanted to get approval that it is a decent idea/I'm not missing something