Mohammad Bagher Abiyat

Results 191 comments of Mohammad Bagher Abiyat

> I guess this is because of new workflow is coming from a fork repo Or maybe because this my first ever PR in vite that it won't allow running...

Hey folks, I wonder if we can get this merged! Let me know if I should try anything before merging this.

I appreciate that from you, sorry, I didn't notice there was codesandbox ci being used here, my mistake! The different lies in that pkg.pr.new is completely Github workflows friendly and...

That'd be amazing, it'd be more appropriate to have them side by side, I'll send a PR soon. Thank you so much for the opportunity. On Tue, 16 Jul 2024,...

Here's the PR #42984, now the only thing remaining is installing the [app](https://github.com/apps/pkg-pr-new)!

hey! thank you so much for the review. i'll look into this and try to resolve it. is it just the test case need to be resolved, or we have...

@lukastaegert hey! i just fixed the tests. it was because of a special case where the name was `toString` and it was referencing the Object.toString rather than returning undefined. I...

sorry i just closed this by misclicking the close with comment button. re-opened now!

Sorry, I was pretty shortsighted on this. I put time the last 4 days on it and I think it's in a much better place right now. Basically all the...

Hey folks, here's an example I've been working on, it has complete PWA/offline support with workbox integration. Most of the changes are in the service-worker.ts and vite.config.ts files. https://github.com/Aslemammad/qwik-pwa-example Solution:...