material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Continuous Releases for material-ui using pkg.pr.new

Open Aslemammad opened this issue 1 year ago • 5 comments

Summary

Hey, I'm Mohammad, from https://pkg.pr.new! Thank you so much all for this piece of art.

Lately we had ant-design using pkg.pr.new for their continuous releases which made me think if this might be useful to material-ui too! This would enable preview releases (like netlify/vercel previews) but for the @mui/material npm package (and other modules too) on each branch, pull request and commit.

Examples

Something like this would be possible:

npm i https://pkg.pr.new/@mui/material@173

And this would install the package from pull request number 173.

npm i https://pkg.pr.new/@mui/material@902743b

And this would bring the commit version of the package.

Motivation

This way, it'd be way easier to try out new pull requests, features and bug fixes. As it allows for a smoother feedback loop on the development cycle of material-ui.

And this would be a huge opportunity for https://pkg.pr.new :)

Feel free to close this if you think it's not necessary!

Search keywords: continuous releases

Aslemammad avatar Jul 13 '24 07:07 Aslemammad

Hi @Aslemammad, at the moment we are using codesandbox ci for this purpose. Are there any significant differences between the codesandbox CI and pkg.pr.new implementation? I'm not necessarily against trying it out if it doesn't negatively impact our CI performance. Would you be interested in opening a PR?

https://ci.codesandbox.io/status/mui/material-ui

Janpot avatar Jul 15 '24 09:07 Janpot

I appreciate that from you, sorry, I didn't notice there was codesandbox ci being used here, my mistake! The different lies in that pkg.pr.new is completely Github workflows friendly and everything happens there as a command next to your other workflows.

I'd love to send a PR but if you folks think codesandbox ci is enough at this case, I'd totally go with it since I prefer you maintainers decide at the end.

And huge shout out to @aarongarciah for recommending me to create an issue and have this discussion with y'all.

Aslemammad avatar Jul 15 '24 20:07 Aslemammad

Codesandbox is working quite well for us so far, besides the occasional hickup once in a while. That makes this issue low priority for us. But I'm not against running pkg.pr.new side-by-side with codesandbox ci as long as it doesn't impact our overall CI runtime. I'll keep this issue open in case you or anyone else would like to pick this up.

Janpot avatar Jul 16 '24 07:07 Janpot

That'd be amazing, it'd be more appropriate to have them side by side, I'll send a PR soon.

Thank you so much for the opportunity.

On Tue, 16 Jul 2024, 11:09 Jan Potoms, @.***> wrote:

Codesandbox is working quite well for us so far, besides the occasional hickup once in a while. That makes this issue low priority for us. But I'm not against running pkg.pr.new side-by-side with codesandbox ci as long as it doesn't impact our overall CI runtime. I'll keep this issue open in case you or anyone else would like to pick this up.

— Reply to this email directly, view it on GitHub https://github.com/mui/material-ui/issues/42922#issuecomment-2230229852, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBMICHDQKOFER3X2TGVOITZMTE4RAVCNFSM6AAAAABK2B7ZFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGIZDSOBVGI . You are receiving this because you were mentioned.Message ID: @.***>

Aslemammad avatar Jul 16 '24 07:07 Aslemammad

Here's the PR #42984, now the only thing remaining is installing the app!

Aslemammad avatar Jul 17 '24 19:07 Aslemammad

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

github-actions[bot] avatar Apr 16 '25 13:04 github-actions[bot]