Pelanes comments

Results 6 comments of


                                            Pelanes

trafficstars

null vs. isNull vs. isEmpty?

Totally agree. As always in code, simplicity and syntax are important

Billing Library version 3 or newer.

It will be great 👯‍♀️

ytFiles still null

For me is working the master-SNAPSHOT release with videos that fail with the v.1.4. Usually the problem are the "vevo" youtube videos. Thank you

ytFiles still null

@ShivamArora try to get all available tags in an array, and get the most suitable for you (smaller video size, bigger, etc). Don't trust in only one or two tags,...

Is this library abandoned?

It hasn't been updated in the last 2 years, but I can confirm that current version 'com.github.lzyzsd:circleprogress:1.2.1' works as expected.

[Bug]: INotificationServiceExtension not call in release apk, but work in debug mode

Same problem here, but solved with `@Keep`. Setting minifyEnabled false worked for release app, so as @jkasten2 said I added `@Keep` to my implementation of `OneSignal.OSRemoteNotificationReceivedHandler` (I'm still in OneSignal...