Ankita Swamy

icon company Broadcom icon location Bengaluru

Results 305 comments of Ankita Swamy

✨ Cancel instance refresh on any relevant change to ASG instead of blocking until previous one is finished (which may have led to failing nodes due to outdated join token)

/approve If E2E is needed, we can add it in follow up PR

Remove legacy labels and handling

`legacyIdentityFinalizer` would be removed as part of [this](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/2451) PR.

:bug: fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts

/test pull-cluster-api-provider-aws-e2e

:bug: fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts

/approve

:seedling: Bump github.com/open-policy-agent/opa from 0.68.0 to 1.4.0 in /hack/tools

/lgtm /approve

:bug: Add validation when PublicIP == true but user-supplied public subnet has MapPublicIPOnLauch == false

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-eks

:bug: Add validation when PublicIP == true but user-supplied public subnet has MapPublicIPOnLauch == false

@r4f4 Can you close this PR in favor of #4892 ?

✨ allow preserving addons on delete

/test pull-cluster-api-provider-aws-e2e-blocking

✨ allow preserving addons on delete

/retest

✨ allow preserving addons on delete

/lgtm