cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
:bug: fix: Fix instance PrivateDNSName when domain-name is set in dhcpOpts
What this PR does / why we need it:
When a VPC sets a DHCPOption's domain-name with a custom DNS name, it's being ignored. Now, with this PR, ensure that during instance creation, the controller checks the DHCPOptions and sets the proper PrivateDNSName.
Signed-off-by: Juan Manuel Parrilla Madrid [email protected]
What type of PR is this?
/kind bug
Which issue(s) this PR fixes :
- https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/1691 Fixes #OCPBUGS-29391
Checklist:
- [x] squashed commits
- [ ] includes documentation
- [ ] includes emojis
- [x] adds unit tests
- [ ] adds or updates e2e tests
Release note:
NONE
Welcome @jparrill!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @jparrill. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I need to change the approach, modifying the status.addresses to change the PrivateDnsName reported instead of change that value directly.
@jparrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-aws-e2e | 82556f89b6dfdfed3120d922b5755ac007703853 | link | false | /test pull-cluster-api-provider-aws-e2e |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Ankitasw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Ankitasw]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Ankitasw it was a good merge? I mean it was failing the cluster creation in E2E isn't it?
@damdo: new pull request created: #4920
In response to this:
/cherry-pick release-2.4
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448
