Olivier Halligon
Olivier Halligon
I've removed the team as reviewer, but honestly I think we could as well merge those docs even if they are not perfect, and iterate later if we find errors...
> Sure, I agree, it is just that the PR is draft I guess, thus no-one is reviewing it (I think)... 🤷 I guess nobody is reading PR descriptions, those...
> @AliSoftware do you have any thoughts about how/when to generate the `en` source `Localizable.string`? Does it make sense to have the PR's that make changes to localizable strings also...
> btw, we already have a release process: Pfnfe0-d4-p2 Neat! 💡 Once the process is more settled (as I assume that checklist might soon change slightly to account for those...
~Not sure what's happening with the `appveyor/pr` CI check, but the failure seems unrelated to to my changes in that PR, since they are about the `Fastlane Fastlane::FastFile Unlock keychain...
> FYI the original fix in this PR doesn't work in cases where you actually need a G2 certificate. Client side filtering becomes necessary in that case. @kabiroberai Ah. Good...
> I'm pretty sure there's an ASC bug at play in the filtering logic, because the G2 case is still [declared](https://developer.apple.com/documentation/appstoreconnectapi/certificatetype) in the OpenAPI spec and I think it continues...
> @Automattic/apps-infrastructure what do you think? Is it worth establishing a convention of moving the xcodeproj folder away from the root if an xcworskpace is in use? Or should we...
Funnily enough, `xcodebuild --help` suggests that one is supposed to be able to specify `-workspace` without `-scheme` when using `-resolvePackageDependencies`… ``` $ xcodebuild --help Usage: … xcodebuild -resolvePackageDependencies [-project |-workspace...
> ...It would also save us from reverse engineer / understand the various Xcode / `xcodebuild` quirks... True… though I'd argue we'd still benefit from understanding which `xcodebuild …` command...