Olivier Halligon

Results 355 comments of Olivier Halligon

Sadly enough I can't do anything about that :( Apple uses the same key for the font attribute both for CoreText that expects a `CTFontRef` and for UIKit that expects...

Nice addition but two questions: - Why the `enabled=NO` then `enabled=YES` [here](https://github.com/AliSoftware/OHAttributedLabel/pull/177/files#diff-361b148a167a9a1ce18fe1721b2608c4R465)? - Couldn't we mutualize some code about detection of the link under the tapped point between the tapGR...

My answer might seem awkward, but I will only agree with you when... I will have some documentation on OHAttributelLabel ! The problem is that if I set it to...

As explained by my previous answer, I understand your requests here but I bet than as soon as I modify the default values, I will have complaints the other way...

We can't do that because this property is only present since iOS6 and OHAttributedLabel is intended specifically to support attributed strings for projects that have to support pre-iOS6 projects (that's...

At least encapsulate the calls to methods introduced in iOS6 like `setAttributedtext:` and all those inside a `respondsToSelector:` test to make it safe against previous SDKs and be sure to...

ref #148 ? Don't hesitate to propose a PR for that, at least to propose a commodity method for setting `NSBackgroundColorAttributeName`

Hi @rhfung I don't recall changing anything regarding text color between 3.4.3 and 3.5.3 ([see diff here](https://github.com/AliSoftware/OHAttributedLabel/compare/3.4.3...3.5.3), especially [this line](https://github.com/AliSoftware/OHAttributedLabel/compare/3.4.3...3.5.3#diff-f7f1e526a4e88d8231e04c1680f058c2L217)). Are you sure this change in behavior you are talking...

- Did you add `aayat` as a subview to your cell? - More important question : do you have the same issue if you use an `UILabel` or is it...

Hello, That's a recurring question asked in my GitHub issues, that's a problem related to CoreText itself and Apple's `CTFrameSetter` that will only render a line if it has enough...