Olivier Halligon
Olivier Halligon
So… I tested the code with `SF-Text-Pro-Regular.otf` (SFSymbols) and I've managed to make it list the glyph names but only the ones for the common textual characters. It won't output...
I agree that there's some inconsistency with Assets exposing a `.color` or `.image` property vs Strings exposing the string directly. There was a reason why we did that back in...
@Dschee Another reason why you might have those `.Image` and `.Color` sub-enums is if you have separate asset catalogs for each. The cases when we create sub-enums under `Asset.` are:...
@Dschee So that's where your sub-enum is coming from, that's because you use separate asset catalogs so we create one sub-enum per catalog, because people separating assets in separate catalogs...
If you want to avoid that sub-enum in your case, you can either: * Create a custom template that removed [those lines](https://github.com/SwiftGen/SwiftGen/blob/master/templates/xcassets/swift4.stencil#L77-L83) from the template (`{% if catalogs.count > 1...
Good point. Example where it makes it useful to have an `ImageAsset` rather than the generated constants returning an `UIImage` directly is that you can pass an `ImageAsset` and query...
Thanks for the PR! We'll try to finish the merge back into monorepo by cleaning a few stuff but will soon look at it right after 👍 Concerning the new...
Another open discussion is: shouldn't those `accessibilityIdentifiers` be strongly typed to match their `XCUIElement.ElementType`? Or is it useless? For now, the templates seem to only generate constants convertible to strings,...
> As for the typing, generally all you need is the string for a lookup. There are some lookup functions in which you can narrow the search using an element...
About `XCUIElement.ElementType` I think we could imagine a hard-coded map in the parser which looks at the XML element's tag name (`` or`` etc) while parsing and knows (via an...