Alan Rominger

Results 261 comments of Alan Rominger

I might change my feelings here, and try the pre_migrate signal instead. So we won't require installer changes.

I think the updated approach here is solid. Marking ready for review.

demos: ``` bash-5.1$ awx-manage migrate Operations to perform: Apply all migrations: auth, conf, contenttypes, dab_rbac, dab_resource_registry, main, oauth2_provider, sessions, sites, social_django, sso CommandError: At a minimum, postgres version 18 is...

In Django itself `find_commands` has evolved significantly. https://github.com/django/django/blob/f302343380c77e1eb5dab3b64dd70895a95926ca/django/core/management/__init__.py#L29 It now defers to `pkgutil.iter_modules` output, which gives `ModuleInfo` where `ispkg` determines if it is included or not. https://docs.python.org/3/library/pkgutil.html#pkgutil.ModuleInfo Exactly where that...

Initial ("yolo") test run is looking good!

A test could be nice too.

The checks here are actually looking fairly okay-ish to me. Just need to get some integration testing results to confirm that nothing unexpected is happening. YOLO 10152

Question: should we also remove the role parents/children sub-endpoint with this change? https://github.com/ansible/awx/blob/7ed0eee60cbd7ceb7b5fb5ef87b6fbcc3d935f39/awx/api/views/__init__.py#L4464-L4489 They won't be correct after this (I'd expect they'll have nothing.

This came up in https://github.com/ansible/awx/issues/2032, as a UI feature, and there was no resistance to the idea.