Andy Holland

Results 23 comments of Andy Holland

From #20 I had also considered adding a configurable guard proc instead of this, to allow for custom matching to wrap jobs rather than it being all-or-nothing, but I couldn't...

@amatsuda @yuki24 sorry for the @ mention, just wondering if anyone has had time to take a look at this? Should I close?

Sorry, just looked into this and it seems that the `dataset` no longer infers `register_as`, you don't need a `base view` unless you're using `rom-repository`, try updating your relation to...

Here's a working example with rom-repository: ``` ruby require 'json' require 'uri' require 'net/http' gemfile(true) do gem 'rom' gem 'rom-http' gem 'rom-repository' end module ROM module MyAdapter class Dataset <...

@solnic I don't think this is needed, I had a similar case when developing a PoC a few years back and just handed off to another class based on the...

Nice work @hudakh, changes look good to me and Unit/Remote tests pass :+1: Still needs workflow approval and review from an AM maintainer.

I haven't done in the past, normally someone just comes along and picks it up.

@hudakh if this is blocking you, you can pull the gem from your fork using the following in your Gemfile: ```ruby gem 'activemerchant', git: '[email protected]:hudakh/active_merchant.git', branch: '1-update-pin-gateway' # or gem...