Kevin Roberto Perdomo
Kevin Roberto Perdomo
Awesome feedback! @ksylvan I've added in the recommended changes. The mounting of the config file is also very clean. Thanks!
Thanks! @gilesheron Side note for everyone that comes across this PR: I'll update the fork occasionally with the latest updates, but the dockerfile itself will clone from the main repo....
Sounds good! Looking forward to the migration! 😄
> Is there a practical need for user shenanigans @ksylvan suggested? Why should we care about permissions inside docker container that has a specific purpose? It's just generally good practice....
> > This is amazing work but we're migrating to go before too long, so it won't be needed. But THANK YOU. > > > > sorry but containerising this...
I can give it a shot later today. Looks like it should be rather straight forward.