Tim Condon

Results 525 comments of Tim Condon

@rafalwojcik can you show the code? Because the session should be initialised on the way in and then read by the remember me middleware on the way out

@mynona if you'd like to do a PR to point to that repo instead then that would be great. I'll poke people to see if we can get an actual...

It should definitely be added to swift.org, I'm indifferent to whether it's duplicated or not, I'm guessing it's easier to have it in one place and just point to swift.org...

Added a couple of brief comments. There's also a failing test we need to investigate

FYI I don't think this patch will be needed - https://github.com/apple/swift-nio/pull/2952

Adding a typealias for `CryptoKitError` to `CryptoError` wouldn't break anything right? All the original stuff would continue to work but people using Swift Crypto would be able to catch and...

@dscreve what are you looking to do with a custom challenge generator? It's an internal implementation detail at the moment

@vsarunas there's a `--disable-confirmation` flag that should fix this

@dankinsoid I think this is a sensible addition. If you want to do a PR go for it!