markdown icon indicating copy to clipboard operation
markdown copied to clipboard

Doesn't compile with XCode 16.1

Open mynona opened this issue 1 year ago • 4 comments

Bildschirmfoto 2024-08-17 um 08 33 25

Issue exists also on XCode 15.4 with toolchain starting from 5.10.0

Thank you for looking into this, Tim!

mynona avatar Aug 17 '24 12:08 mynona

@0xTim Hi, I found out that if I use as underlying cmark package the apple version your code compiles without issues:

.package(url: "https://github.com/apple/swift-cmark.git", from: "0.4.0"),

Copy-Pasted your wrapper code to test this.

Maybe this input is of use.

mynona avatar Aug 17 '24 16:08 mynona

@mynona if you'd like to do a PR to point to that repo instead then that would be great. I'll poke people to see if we can get an actual release of the cmark library

0xTim avatar Aug 19 '24 13:08 0xTim

@0xTim @mynona I've done a PR for this https://github.com/vapor-community/markdown/pull/15

handya avatar Oct 11 '24 23:10 handya

Thank you @handya ,

There is also this repository (as pointed out by Tim): https://github.com/swiftlang/swift-markdown

I migrated there. I found one rendering bug that I reported and unfortunately they have their versioning in sync with swift versions. Therefore, the markdown rendering feature is at the moment just part of the main branch.

Maybe to reflect if the official repo should be used in the future in general? The downside is that this repo is a very small wrapper over the c-library and the official swift repo is not that slim.

mynona avatar Oct 12 '24 07:10 mynona