Thomas Klausner

We've just fixed this, please try [git head](https://github.com/nih-at/libzip/commit/ac29119bee5261dd2152b9c8c2c897a6203ad8ad)

Thanks for the comment. I've tried that too, but see an endless loop of these messages: ``` ===> Building for ladybird-0.0.0nb20240227 [0/2] Re-checking globbed directories... [1/2] Re-running CMake... -- Configuring...

I'm compiling on NetBSD. As I understand it, both functions are glibc extensions and should be hidden by `ifdef(__linux__)`. I use this for now: ``` --- Userland/Libraries/LibCore/Environment.cpp.orig 2024-02-27 18:09:19.633132086 +0000...

Thanks, I'll use `AK_OS_NETBSD`. pkgsrc doesn't like temporary `RPATH`s. only the final installation `RPATH` is allowed. So the `LD_LIBRARY_PATH` workaround is fine. Does Linux even provide a native `popcount`? NetBSD...

I think you're right, from [NetBSD's mmap man page](https://man.netbsd.org/mmap.2): ``` MAP_ANON Map anonymous memory not associated with any specific file. The file descriptor is not used for creating MAP_ANON regions,...

One patch later: ``` --- Userland/Libraries/LibJS/Heap/BlockAllocator.cpp.orig 2024-02-27 18:49:14.164744463 +0000 +++ Userland/Libraries/LibJS/Heap/BlockAllocator.cpp @@ -52,8 +52,10 @@ void* BlockAllocator::allocate_block([[m return block; } -#ifdef AK_OS_SERENITY +#if defined(AK_OS_SERENITY) auto* block = (HeapBlock*)serenity_mmap(nullptr, HeapBlock::block_size, PROT_READ...

C++ is not my forte, but from a short review this looks fine. I assume: ``` TRY(addresses.try_append(*result)); ``` makes a copy of the result and doesn't move it? What is...

Since @ADKaster was so nice proposing a pull request with fixes, I wanted to try it out, but the build fails early for me right now: ``` [69/2584] Linking CXX...

So I tried ladybird with the proposed patches from the pull request, the one in the comment https://github.com/SerenityOS/serenity/issues/23375#issuecomment-2103255960 and the last one from comment https://github.com/SerenityOS/serenity/issues/23375#issuecomment-1967342898 (constexpr) on NetBSD, and it...

You might be on the right track, I just found https://github.com/NetBSD/src/blob/9bda4630351909a1a74baa7c5b3e2fbb1553b941/lib/libc/net/getaddrinfo.c#L42-L44 I'll try it and report back.