Thomas Klausner
Thomas Klausner
Looks like you're well on your way already, great!
Do you have a pointer to documentation about using subprojects with CMake and best practices for variables in that case? This change is quite invasive since all packagers and users...
I don't see it, but since this was only a proposal, you could fix this in your pull request :-)
We have no Windows expertise, so help is welcome. Reading https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#maximum-path-length-limitation my guess is that your file name is too long. There is a magical prefix you can add to...
We have no Windows expertise. I wasn't even aware that Windows now supports symlinks. I thought this was implemented as .LNK file (which is a normal file which references the...
No, I don't think he is. But that's a good idea - removing `| FILE_ATTRIBUTE_REPARSE_POINT` there might improve the situation for symlinks. @ktakahashimtb Can you please give this a try?
In your testing, please also try changing the file and report back if the symlinks is overwritten with a file, or the symlink target is replaced instead.
That's good progress. I was expecting that the symlink would be replaced with a file, that's why I asked... Please let us know if you make progress on that end...
I tried thinking about it some more, but I still don't understand what you describe in the last comment. It doesn't really matter at what time the archive is written...
Using your timestamp I've added a test that documents the current behaviour - the date is reset to the default date (somewhere in 1980) because the time stamp at 2:30...