html-agility-pack icon indicating copy to clipboard operation
html-agility-pack copied to clipboard

An attribute read without quotes is written without quotes even after the value has been set

Open POFerro opened this issue 1 year ago • 2 comments

Hi @JonathanMagnan ,

I stumbled upon a situation where an attribute that is read without quotes is written without quotes even after gaining a value. This is when the GlobalDefaultQuote type is set to initial on the document, the attribute gets this value on Value set and then writes no quotes when serializing.

I created PR #564 to correct this issue, could you please have a look?

Thanks and best regards

POFerro avatar Aug 14 '24 14:08 POFerro

Hello @POFerro ,

Sure, I will take a look this weekend :)

Best Regards,

Jon

JonathanMagnan avatar Aug 14 '24 15:08 JonathanMagnan

Hello @POFerro ,

Thank you again for your contribution. Indeed, that was a good catch for this special case.

Your PR has been merged and released in the v1.11.64

Best Regards,

Jon

JonathanMagnan avatar Aug 19 '24 23:08 JonathanMagnan