System.Linq.Dynamic.Core Applied case sensitivity settings to KeywordsHelper

Applied case sensitivity settings to KeywordsHelper

Open abbasc52 opened this issue 2 years ago • 16 comments

Extended case sensitivity settings to KeywordHelper

Aug 15 '23 14:08 abbasc52

@StefH, I am unable to find the right place to add test cases for this, could you guide me?

Aug 15 '23 14:08 abbasc52

@abbasc52

Changing this could break some existing usage. So in case this functionality is added, a new setting KeywordsAreCaseSensitive is needed.
Add a new test here \Parser\KeywordsHelperTests.cs

Aug 16 '23 15:08 StefH

@StefH Addressed your comment and added test cases, please review again

Aug 27 '23 15:08 abbasc52

@StefH when can we merge/release this PR?

Oct 21 '23 12:10 abbasc52

@StefH when can we merge/release this PR?

I'll take a look.

Oct 21 '23 15:10 StefH

because of PR https://github.com/zzzprojects/System.Linq.Dynamic.Core/pull/755, this PR needs to be updated....

Oct 29 '23 08:10 StefH

@StefH I have updated the PR. Although looking at your PR, you seem to have fixed case issue with custom types. This PR will only help people make Context keywords case sensitive via config . I will leave it upto you if you want to complete this PR.

Nov 25 '23 10:11 abbasc52

My original goal of this PR was to make predefined and custom types case sensitive :)

Nov 25 '23 10:11 abbasc52

@abbasc52 See my review comments.

Nov 28 '23 16:11 StefH

@StefH fixed the review comments

Jan 13 '24 08:01 abbasc52

@abbasc52 See my review comments.

Jan 23 '24 12:01 StefH

@abbasc52 See my review comments.

Feb 07 '24 07:02 StefH

Hello @abbasc52, can you please take a look at my review comments?