EntityFramework.Extended icon indicating copy to clipboard operation
EntityFramework.Extended copied to clipboard

Changed the internally used System.Linq.Dynamic namespace

Open mstancombe opened this issue 10 years ago • 1 comments

Changed the internally used System.Linq.Dynamic namespace so it is project specific, to avoid interfering with references in other projects. Means that we can reference both this and System.Linq.Dynamic in the same project. Fixes issue #114

the options were

-reference the nuget for System.Linq.Dynamic (which can't be done thanks to strong naming hell) -change this library to not be strong named (which will result in gnashing of teeth from those who are currently using strong naming) -do as this checkin does, and change the namespace so it's project prefixed and won't collide with other libraries.

Went with the last option as it seems path of least resistance. Only breaking issue could be users who have decided to reference this library, and then gone on to use the dynamic linq contained package will have to update their own referenecs. Ideally they should instead be referencing the nuget package, but irrespective, they definitely shouldn't be referencing this package for the purpose of using dynamic linq, and this chagne will not cause unexpected behaviour, it will cause a very obvious compile error.

mstancombe avatar Feb 11 '15 22:02 mstancombe

I'm seeing an ambiguity issue when trying to do a Where clause with the string predicate. Is it possibly related to this? I'm running dev build 146 and it's still happening. Have both Dynamic and Extended (reference in separate NuGets) in the same project. As soon as I uninstall Extended the problem goes away. Thanks!

BStrat77 avatar Apr 22 '15 11:04 BStrat77