EntityFramework.DynamicFilters icon indicating copy to clipboard operation
EntityFramework.DynamicFilters copied to clipboard

MulticastDelegate change to Func<DbContext ,Object>

Open tangdf opened this issue 7 years ago • 1 comments

The DynamicInvoke method of MulticastDelegate is too poor.

https://github.com/tangdf/EntityFramework.DynamicFilters/blob/7ed94eb3a45ff141f0c7ea8fbec9a405e53ca2f2/src/DelegateBenchmark/DelegateInvoking.cs#L10-L40

Benchmark results:

Method Mean Error StdDev
MulticastDelegate_DynamicInvoke 528.562 ns 2.5630 ns 2.3974 ns
FunDelegate_Invoke 3.573 ns 0.0227 ns 0.0202 ns

tangdf avatar Jan 16 '18 05:01 tangdf

Hello @tangdf ,

Thank you for reporting, we will look at it.

I'm not sure yet how we will handle this change since we want to stay backward compatible. We might support both (your solution and the MulticastDelegate)

Best Regards,

Jonathan


Help us to support this library: Donate

JonathanMagnan avatar Jan 16 '18 12:01 JonathanMagnan