zzydxm

Results 31 comments of zzydxm

updated https://github.com/zzydxm/otp/commit/eec6f9a7ea901daa344ff5d799b6cac847ab6ddf which added ssl_gen_statem:ktls_handover and moves set_ktls into inet_tls_dist

> I think we can have a new state for it, similar to the downgrade state but for handling "ktls_offlad". I am not sure about what would be the best...

> The alternative to making a sub-binary is to reallocate the binary. I suspect creating a sub-binary was chosen for speed reasons. Your suggestion may be a good compromize. We...

Found the line that causes the issue: https://github.com/erlang/otp/commit/e165a3368da#diff-280aa9e67bfae54121bde3ed8b7e1eea6f845f68ca0600c96331fbacb315672bL3034-L3040 Previously, if no issuer found, it will try to use Session = Session0#session{sign_alg = SelectedSignAlg,own_certificates = EncodedChain,private_key = Key}, but after the...

> one of the certificates in the certificate chain SHOULD be issued by one of the listed CAs Isn't it saying one of the client certificates should be issued by...

> What kind of Erlang node distribution are you running? Default TCP, TLS or something else? We use kernel TLS offload, which is a customized proto_dist (we did not change...

another coredump that might related to this, happening on GC: ``` (gdb) bt #0 0x0000000000682f4a in ethr_native_atomic64_add_return_mb (incr=-1, var=0x1d) at ../include/internal/x86_64/../i386/atomic.h:240 #1 ethr_atomic_add_read (val=-1, var=0x1d) at ../include/internal/ethr_atomics.h:4219 #2 ethr_atomic_dec_read (var=0x1d)...

> What OTP version is this? also OTP 25 RC3, should be ee8872b0f2528985306e8b2299920eb445a0c30f

This should be related to https://github.com/erlang/otp/issues/6247

Right, it works for me on linux 5.12.0. Maybe we can remove the ServerTx/ClientTx check? ``` 2> inet:getopts(Server, [{raw, 6, 31, 3}]). {ok,[{raw,6,31,}]} 3> inet:getopts(Server, [{raw, 282, 1, 56}]). {ok,[{raw,282,1,}]}...