space before terminal on HiDPI

[Kolcha]

I recently updated this extension from extensions.gnome.org. the issue with strange position now is fixed, but old issue with HiDPI display (https://github.com/zzrough/gs-extensions-drop-down-terminal/issues/84 https://github.com/zzrough/gs-extensions-drop-down-terminal/issues/87) is back: Hardware: MacBook Pro with Retina display OS: Fedora 23 GNOME Shell: 3.18.1 extension version: 19 (got from metadata.json)

[sphinx9]

I have this same issue. Hardware: Dell XPS 13 DE (3200x1800) OS: Fedora 23 GNOME Shell: 3.18.3 Extension version is newest I guess..

[chenxilong]

I have this same issue too. Hardware: Chromebook pixel 2013 OS: Ubuntu 14.04 GNOME Shell: 3.18.3 Extension version: install from https://extensions.gnome.org/ today

[mario-tux]

Same hardware of @sphinx9, gnome shell 3.18.3: same gap!

Using Wayland the gap is not present; same OS (Arch Linux), same Gnome Shell installation.

[muhsli]

Hi, I came here too see if I were alone or if there were more people with the same problem. I am having the same issue. Hardware: Retina MacBook Pro 13" 2015 OS: Ubuntu 15.10 GNOME Shell: 3.18.2 extension version: 19

[emilhem]

I'm having the same issue.

Hardware: Dell XPS 13 DE (3200x1800) OS: Ubuntu Gnome 15.10

[fmujakitz]

I was having the same issue Ubuntu Gnome ThinkPad P50, 4K screen

After going through reported issues, found that this was fixed on earlier versions. It appears that this was missed on newer ones.

// applies the change dynamically if the terminal is already spawn
        if (this._busProxy !== null && this._windowHeight !== null) {
            ///this._busProxy.SetGeometryRemote(this._windowX, this._windowY, this._windowWidth, this._windowHeight);
            if (SHELL_VERSION < 3.14) {
                this._busProxy.SetGeometryRemote(this._windowX, this._windowY, this._windowWidth, this._windowHeight);
            } else {
                this._busProxy.SetGeometryRemote(this._windowX, this._windowY - panelBox.height, this._windowWidth, this._windowHeight);
            }
        }

Removed my first comment.

[Kolcha]

thanks a lot, fixed extension using code from @fmujakitz second post

comment line as in first post has no effect for me using both change broke extension

[muhsli]

Can confirm, it fixes my error as well. Thank you @fmujakitz

[jonkri]

Thanks for this!

I can confirm that the fix works with the v19 code. However, it doesn't work on v20 for me.

[ouafnico]

Same issue on hidpi / Archlinux.

[tomMoral]

I ran in the same issue.

It appears to be caused by a missing scaleFactor in extension.js, l.518, that causes HiDPI to display space between the top bar and the terminal

case TOP_EDGE:
    this._windowX = x1;
->  this._windowY = panelBox.y == y1 ? y1 + panelBox.height/scaleFactor: y1;
    this._windowWidth = screenWidth;
    this._windowHeight = this._evaluateSizeSpec(sizeSpec, true);
    break;

[shihrer]

@fmujakitz's fix worked for me. Thanks.

[jonkri]

@shihrer: On which version?

[shihrer]

@jonkri Of the extension? Not sure, whatever is available on extensions.gnome.org.

[jonkri]

@shihrer: Looking at extensions.gnome.org, that seems to be version 20. This is a bit odd, since applying @fmujakitz's fix on version 20 didn't work for me (as reported in my comment above) - I had to use version 19. Maybe I did something wrong...

[jonkri]

@shihrer: Would it be possible for you to verify that you indeed run version 20 (you can see this in the JSON file)? If you do, perhaps you could diff your extension.js with the one from version 20 to make sure that all you changed is @fmujakitz's comment.

[AthanasiusOfAlex]

@fmujakitz's fix basically works, except that the scale factor needs to be taken into account (especially in HiDPI displays):

// applies the change dynamically if the terminal is already spawn
        if (this._busProxy !== null && this._windowHeight !== null) {
            ///this._busProxy.SetGeometryRemote(this._windowX, this._windowY, this._windowWidth, this._windowHeight);
            if (SHELL_VERSION < 3.14) {
                this._busProxy.SetGeometryRemote(this._windowX, this._windowY, this._windowWidth, this._windowHeight);
            } else {
                this._busProxy.SetGeometryRemote(this._windowX, this._windowY - panelBox.height/scaleFactor, this._windowWidth, this._windowHeight);
            }
        }