customLayout icon indicating copy to clipboard operation
customLayout copied to clipboard

Published 20 hours ago • verified publisher icon zzawadz

test phl_adjust_table

Open davidgohel opened this issue 4 years ago • 0 comments

Hello,

Since I made changes in theme functions and default values of flextable, a test broke in customLayout (https://github.com/zzawadz/customLayout/blob/master/tests/testthat/test-flextable.R#L24). It's because:

  • The padding is now 3 for the bottom, top, left, right, it was 2, 2, 5, 5,
  • The default font is now chosen according to the platform and is no longer "Roboto or Arial".

Could you add testthat::skip_on_cran() to this test? Or maybe drop it. It freezes flextable to its current state. This is not a regression nor a bug, it's a change, this test should not be blocking.

KR David

davidgohel avatar Oct 23 '20 08:10 davidgohel