zzambers

Results 110 comments of zzambers

> Just side note, you tried that image in jtregs then, right? I have not tried to run jtregs with generated image, just examined that libraries for gtest are there.

Results in GHA appeared, there i build failure on windows `jdk17u` (other ones pass). I looked into it a bit: **Error**: ``` d:\a\temurin-build\temurin-build\workspace\build\src\test\hotspot\gtest\metaprogramming\test_enableIf.cpp(73): error C2244: 'TestEnableIfNested::sub1': unable to match function...

Correction: All windows builds use VS 2022. Even though GHA workflow installs VS 2019 on jdk11u and jdk17u, configure output shows, that VS 2022 is actually used everywhere: ``` *...

I have done quite a lot of testing locally with `VS 2022` today and found, that jdk17 build actually passes with older version of VS 2022: ``` configure: Using microsoft...

I am now in process of bisecting jdk commit, which fixes this issue on newer jdks. (hopefully it will put more light on the problem)

And the winner is [JDK-8317132](https://bugs.openjdk.org/browse/JDK-8317132) :) I don't see any change to relevant code, so it seems like adding `-permissive-` argument to compiler avoids the issue in newer jdks. This...

I have filled issue for Visual Studio: https://developercommunity.visualstudio.com/t/OpenJDK-jdk17u-build-failure-with-VS20/10860335

@FrankXie05 Thank you for the swift reply. I was able to come with reproducer. I attached it to VS issue.

> @zzambers Thank you for the example, this is the result of my local test: My compiler versions (VS 2022): `19.43.34808.96`. And I also tested it with the latest compiler...

I think download of googletest is probably just random infra issue. The other runs show build problem on jdk+win: ``` d:\a\temurin-build\temurin-build\workspace\build\src\src\java.base\share\classes\java\lang\invoke\MethodHandleNatives.java:558: error: cannot find symbol VarHandleGuards.class, getVarHandleGuardMethodName(guardType), ^ symbol: class...