argo icon indicating copy to clipboard operation
argo copied to clipboard

Should I make a Pull Request of my fork?

Open oliverpool opened this issue 8 years ago • 2 comments

Hi,

I need to control an aria2 daemon from go and I found your library. I found it quite neat and I wanted to improve it (to improve my "go-writing" skills ^^).

I took the liberty of creating a fork and reorganizing it quite heavily : https://github.com/oliverpool/argo (I tried to make a nice godoc page, with a complete example : https://godoc.org/github.com/oliverpool/argo).

I you want, I can make a PR to merge it into your library (it will break all compatibility) or we can let them live separately (You can see diff : https://github.com/zyxar/argo/compare/master...oliverpool:master).

I did not implement the system.multicall RPC method yet (because it is quite complicated). But maybe I could implement it using a special Caller which could gather them and send them all at the same time.

oliverpool avatar Jul 07 '17 14:07 oliverpool

Wow, that seems like a rewrite of the package. But since I don't have enough time to look into your changes carefully, (and the compatibility issue) I think it better to let them live separately. It serves well in several of my personal projects.

Anyway, thank you.

zyxar avatar Jul 11 '17 02:07 zyxar

BTW, it's not necessary to implement system.multicall since imo it's not that practical to call such method from Go.

zyxar avatar Jul 11 '17 02:07 zyxar