[Bug] Playback repeats if song in playlist is not found

[Skivling]

Description

If there is a song in a playlist whose path doesn't exist or has been deleted, it will cause a bug and loop the song before that in the play queue.

Steps to Reproduce

1. You must have a playlist with some songs referenced that Symphony can't get to, or have been deleted and not removed from the playlist
2. Either play normally or shuffled
3. Go onto the play queue, and look at the numbers.
4. It should go from 1,2,3,4, but find where it skips a number, like 17, 19
5. Play the song before the skip (in example it is 17)
6. After it finishes that song, it will try to play the next but because it's not found it will just loop song (17) continuously until it is resolved manually

Expected Behavior

Symphony should notice that songs referenced in playlists do not exist, and have a UI element which allows easy remove / remap the songs. e.g. If a song used to be in music/%artist% , and is now in music/%artist%/%album% , the playlist still references it as the original. The listener is asked if they want to remove from playlist or tell Symphony where it is now.

Screenshots

N/A , can supply if needed

Device

• Device: Samsung Galaxy A12
• OS: Android 13

Additional Context

N/A

Checklist

• [x] I have read the Contribution Guidelines.

[zyrouge]

Songs that do not exist in storage will not be parsed by Symphony. It would be helpful if you attach a clip of it happening. Also, skipping missing songs depends on which loop mode the playback is using.

[Skivling]

I got a 'This video is too big' error, so I put it on my website instead: https://skivling.codeberg.page/share/2024-04-19_Symphony-Bug.mp4

[zyrouge]

How did you get the queue to skip a number? That shouldn't be happening.

[Skivling]

I clicked the three dots on my main playlist and pressed 'shuffle play'. I have lots of albums of songs which for a while used to be the the root music directory, then one time I auto-sorted them by artist/album, so there are a lot of remainders which Symphony can't find the original directory.

[zyrouge]

~What I actually mean is that, the queue cannot skip an index. It is always sequential. But, I your case index 18 was missing which should not be happening at all. This skipping of index is probably what cause the playback to stop.~

I guess you removed the song after being added to the queue? Either way, this shouldn't have happened at the first place. I still need steps to reproduce it issue to find the actual cause of this.

[Skivling]

If I play the playlist without shuffle it puts all the not found song files at the end of the queue.

Steps:

1. Have an existing playlist with 30 songs
2. Go into file manager and rename some song files or change their directory, do 6 of them (it doesn't matter how many)
3. Make Symphony re-scan the library
4. Find the playlist, click the 3 dots and press 'shuffle play'
5. inspect the play queue, you should find the bug.

or 4. Find the playlist, and click the play button to play in order 5. It should say there are 30 songs in the playlist, but if you go to the bottom of that play queue the last number will be lower (24 if you changed 6 before).

In my playlist, it says it has 201 songs. If I do the second group of 4+5 steps, the final item in the queue is number 181. So I have 20 songs which can't be found.