ionic-image-loader icon indicating copy to clipboard operation
ionic-image-loader copied to clipboard

Ionic 4 - plans for compatibility

Open cezarykluczynski opened this issue 6 years ago • 15 comments

Are there any plans to make Ionic Image Loader compatible with Ionic 4?

Currently it can't be used with Ionic 4 because of error:

ERROR in node_modules/ionic-image-loader/dist/providers/image-loader.d.ts(3,26): error TS2307: Cannot find module 'ionic-angular'.

cezarykluczynski avatar Oct 07 '18 14:10 cezarykluczynski

Running into the same problem. Tried implementing it,got stuck along the way.

newtonmunene99 avatar Oct 14 '18 16:10 newtonmunene99

+1

mateusduraes avatar Oct 17 '18 20:10 mateusduraes

+1

crebuh avatar Oct 18 '18 13:10 crebuh

Would be great

ruudboon avatar Oct 19 '18 10:10 ruudboon

In the works, please be patient :)

madoBaker avatar Oct 24 '18 04:10 madoBaker

Sweet! Thnx @madoBaker

ruudboon avatar Oct 25 '18 05:10 ruudboon

Is the v4 branch the working branch for this? Can we help with some pull requests?

ruudboon avatar Nov 17 '18 05:11 ruudboon

Is the v4 branch the working branch for this? Can we help with some pull requests?

Correct, and PR's are greatly appreciated!

madoBaker avatar Nov 17 '18 21:11 madoBaker

+1 Still not working on Ionic 4 ERROR in node_modules/ionic-image-loader/dist/providers/image-loader.d.ts(3,26): error TS2307: Cannot find module 'ionic-angular'.

mtshare avatar Feb 11 '19 17:02 mtshare

for me it worked using the beta version: npm i -S ionic-image-loader@beta

simbig avatar Mar 13 '19 07:03 simbig

+1 Still not working need it urgently!! :(

tbthiago avatar Jun 17 '19 23:06 tbthiago

still not working on ionic 4

jokabuyasina avatar Aug 08 '19 12:08 jokabuyasina

Using [email protected] and @ionic-native/[email protected] now and it works.

abePdIta avatar Aug 28 '19 09:08 abePdIta

+1 Still not natively working on ionic 4 and we're halfway through 2020

I can confirm @abePdIta solution works tho, I installed both packages and edited my app.module.ts as such:

import { WebView } from '@ionic-native/ionic-webview/ngx'; import { IonicImageLoader } from 'ionic-image-loader';

IonicImageLoader.forRoot() in the imports array, WebView in the providers array then also add IonicImageLoader in your page's module imports array.

Fieel avatar Jun 23 '20 12:06 Fieel

The build works with @abePdIta's solution and the beta version in Ionic 5 with Capacitor but it fails on an Android device with the error:

Uncaught TypeError: Cannot read property 'id' of undefined
    at registerNgModuleType (/vendor-es2015.js:81976)
    at /vendor-es2015.js:81987
    at Array.forEach (<anonymous>)
    at registerNgModuleType (/vendor-es2015.js:81987)
    at new NgModuleFactory$1 (/vendor-es2015.js:82084)
    at compileNgModuleFactory__POST_R3__ (/vendor-es2015.js:85628)
    at PlatformRef.bootstrapModule (/vendor-es2015.js:85866)
    at Module../src/main.ts (/main-es2015.js:3464)
    at __webpack_require__ (/runtime-es2015.js:85)
    at Object.0 (/main-es2015.js:3477)

madmacc avatar Aug 25 '21 05:08 madmacc