project-ar2 icon indicating copy to clipboard operation
project-ar2 copied to clipboard

Banner Image Aligning with Navigation Menu

Open magaman opened this issue 12 years ago • 4 comments

This wasn't an issue a few weeks back, but the latest code has the banner image within the navigation menu container, example http://imgur.com/uxjcj

Here is my header code

<header id="header" role="banner">
    <div id="branding" class="clearfix">
                <hgroup class="logo">
            <h1 class="blog-name"><a href="http://localhost:8888">VGR Test</a></h1>
            <h2 class="blog-description"></h2>  
        </hgroup>

        <div class="banner">
        <img src="http://img.vgrevolution.com/newvgrlogo1.png">
        </div>

    </div><!-- #branding -->
</header><!-- #header -->

magaman avatar Sep 01 '12 01:09 magaman

Figured out where the problem might be, if you turn on "Show Header Text" in the header options, the logo will be in the correct spot in the header, but obviously the text is visible behind it.

I got a feeling it has to do with the last changes made to styles.php for the clickable header

magaman avatar Sep 02 '12 19:09 magaman

Yes that's an unfortunate consequence of allowing clickable headers. I'll guess I'll have to come up with a better solution for v2.1.

zyml avatar Sep 24 '12 14:09 zyml

Why not just stick to having it clickable through the logo image and/or could it be posible to add a default "home" icon to the menu. Having the entire header clickable seems overkill.

magaman avatar Sep 24 '12 15:09 magaman

I'll be adding the functionality of uploading an image logo for the next patch, so the logo image will only be clickable and your banner should be working again.

zyml avatar Oct 09 '12 18:10 zyml