private-gpt icon indicating copy to clipboard operation
private-gpt copied to clipboard

Added GUI for Using PrivateGPT

Open msrivas-7 opened this issue 2 years ago • 12 comments

Now user can just run python gui.py to start a GUI that will let you send queries and see answer and sources in a window, also keeps the history of all questions and answers until clicked on reset button to reset answer box.

Screenshot 2023-05-11 at 11 03 07 AM

msrivas-7 avatar May 11 '23 18:05 msrivas-7

Please try this and let me know if there's any feedback on how I can make it better.

msrivas-7 avatar May 11 '23 18:05 msrivas-7

Looks good!!! Got a couple suggestions in the review for you to check^

Nice. 😁

R-Y-M-R avatar May 11 '23 18:05 R-Y-M-R

I can't see any review or suggestions, where can I find the suggestions? and will you be able to merge this PR?

msrivas-7 avatar May 11 '23 18:05 msrivas-7

I have fixed the changes requested.

Here's the screenshot of it working after the changes: Screenshot 2023-05-11 at 12 04 28 PM

msrivas-7 avatar May 11 '23 19:05 msrivas-7

Nice! I can't merge btw so have to wait for imartinez to review.

R-Y-M-R avatar May 11 '23 19:05 R-Y-M-R

A couple thoughts:

First of all, this is amazing! I really like the idea. But I think we could explore the idea a little bit more. After reading this https://github.com/imartinez/privateGPT/issues/54 I feel it'd be a great idea to actually divide the logic and turn this into a client-server architecture. The gui in this PR could be a great example of a client, and we could also have a cli client just like the current one. Would like to know your thoughts.

As a secondary thought, if we were to push that client-server idea to the future and merge this PR to get started, I'd ask you to update the branch with main latest changes, and to make sure the answer_query implementation doesn't duplicate code but reuse the same code as main(), probably extracting the logic inside main() to a reusable function

imartinez avatar May 12 '23 08:05 imartinez

I think that's a great idea just read this #54 I like the idea of dividing the logic and making this gui into a client interface. I update my branch with latest changes, I can look into reusing the code from main()

msrivas-7 avatar May 12 '23 08:05 msrivas-7

Hey @imartinez I just pushed a commit now its reusing the same code for both main() and answer_query() functions it's also synced with main branch

msrivas-7 avatar May 12 '23 09:05 msrivas-7

In general terms @msrivas-7 , and trying to manage expectations, I'd like to test it thoroughly before merging it. Also an update to the readme would be required. I do love the approach, and think the community will really like it!

imartinez avatar May 12 '23 10:05 imartinez

@imartinez I quickly updated ReadMe, Let me know your thoughts. I will work on resolving the above review later today.

msrivas-7 avatar May 12 '23 17:05 msrivas-7

Here is my PR about UI Chat simple (Link PR: https://github.com/imartinez/privateGPT/pull/91)

vnk8071 avatar May 13 '23 13:05 vnk8071

H2O.ai has a similar PrivateGPT tool using same BE stuff with gradio UI app: https://github.com/h2oai/h2ogpt

Video demo demo here: https://www.youtube.com/watch?v=1JLi0ioz_XM

Feel free to use h2oGPT (ApacheV2) for this Repository!

Our langchain integration was done here, FYI: https://github.com/h2oai/h2ogpt/pull/111

image

pseudotensor avatar May 16 '23 04:05 pseudotensor

This comment might just add noise and I apologize in advance if it does. I just wanted to congratulate and thank everyone, as a mere spectator and, in this case, consumer, for your great contribution. Your work crystallizes that open source means.

Again, thank you all.

pachico avatar Jul 08 '23 09:07 pachico

Hi, Where do I get the gui extension for privateGPT and how do I install it? Thanks

Imagoculturae avatar Aug 25 '23 11:08 Imagoculturae