private-gpt icon indicating copy to clipboard operation
private-gpt copied to clipboard

fix exit bug

Open bearney74 opened this issue 1 year ago • 1 comments

when someone types exit, the program does not exit. This pull request fixes that bug, and allows any input that starts with exit (or quit) in upper/lower, or mixed case to terminate the program.

bearney74 avatar May 22 '23 15:05 bearney74

Modal text interfaces are a pain, but I would take the traditional ^C over starting to pick commands out of innocent text. Soon enough there will be proper UI to offer quit options in a way that won't cause unintended failures. We should have no magic words in the text. If you must do something like this, have exactly one word and the query must be that word exactly with no other characters. Have two words and you will soon have ten. Still a bad idea.

johnbrisbin avatar May 24 '23 02:05 johnbrisbin

I had the same problem. I am using the app on WSL. My Ubuntu os froze after I type exit. I fixed the problem by terminating the process after the while loop.

kenancum avatar Aug 01 '23 11:08 kenancum