micro icon indicating copy to clipboard operation
micro copied to clipboard
verified publisher icon zyedidia

Nftables improvements

Open theredcmdcraft opened this issue 1 year ago • 7 comments

See also old PR: #3325

theredcmdcraft avatar Oct 22 '24 19:10 theredcmdcraft

@JoeKar can you have a look on the file again, that we can finish this PR?

theredcmdcraft avatar May 27 '25 12:05 theredcmdcraft

I can, but can you please answer my question in https://github.com/zyedidia/micro/pull/3517#discussion_r1899124532? Please do not merge the master into your feature branch, but rebase your feature branch against the upstream master. This will keep the PR commit history clean.

JoeKar avatar May 27 '25 19:05 JoeKar

Ohhh ooops. i think that was wrong...

theredcmdcraft avatar May 27 '25 20:05 theredcmdcraft

I can, but can you please answer my question in #3517 (comment)?

I don`t know what my intent was. The commit where i changed this line is from November 30th, 2024. It is some time ago. sorry

theredcmdcraft avatar May 27 '25 20:05 theredcmdcraft

I think that looks a little bit better. Sorry for stupidity.

theredcmdcraft avatar May 27 '25 20:05 theredcmdcraft

I think that looks a little bit better. Sorry for stupidity.

Not really, there are 64 changed files, while there should be only one.

JoeKar avatar May 28 '25 08:05 JoeKar

I can, but can you please answer my question in #3517 (comment)?

I don`t know what my intent was. The commit where i changed this line is from November 30th, 2024. It is some time ago. sorry

When there is no use case it, why keep it?

JoeKar avatar May 28 '25 08:05 JoeKar