zyedidia
Unicode: Fix wide runes in various scenarios
- [x] remove
@replacement char for incomplete wide runes - [x] fix tabbar
>marker with wide runes - [ ] fix tabbar tab activation with wide runes
- [x] fix infobar prompt with wide rune name -> #3919
- [ ] fix line flickering in bufwindow in case of selected wide rune string and window resize
Fixes #2277 Fixes #3514
That's cool, it fixes the search issue. But it has some edge-case that isn't covered.
if you e.g paste 少女少女 少 女少女少女少 女少少女 into the window and then start resizing, you can still make the '@' appear.
Ok, I will have a look into this in the evening. Looks like the „fix“ is just half of the truth and this Unicode handling needs some rework.
@dmaluka:
Maybe it is better to process such long-runners within micro's upstream repository instead of our forks. Then we've the chance that every contributor with write access can directly support/proceed/take-over etc.pp.
What do you think?
You mean, create a branch in this repo (https://github.com/zyedidia/micro)? If needed, we always can, but I'm not sure why are asking about it here. Speaking of this PR, I simply had no time to look into it yet, and also I saw it marked as "draft" so I didn't prioritize it.
You mean, create a branch in this repo (https://github.com/zyedidia/micro)?
Yes.
If needed, we always can, but I'm not sure why are asking about it here.
The contribution of different people in PRs from a different repositories isn't as easy as it is in the upstream one. In other words: If you have time and desire then you could contribute in such a branch too.
This was the idea behind this question.
Speaking of this PR, I simply had no time to look into it yet, and also I saw it marked as "draft" so I didn't prioritize it.
The intention of my question wasn't about a review (see above), so no hurry.