micro icon indicating copy to clipboard operation
micro copied to clipboard

Fix Makefile syntax matching := and : as targets

Open petabyt opened this issue 1 year ago • 2 comments

Before and after: Screenshot at 2024-01-13 01-15-53 Screenshot at 2024-01-13 01-16-06

petabyt avatar Jan 13 '24 06:01 petabyt

This change would cause recipes like a:b (without space) to get highlighted wrong. I would argue in your example VCAM_CORE should be highlighted as an identifier. Maybe the pattern for identifier should instead be changed to something like this?

- identifier: "^[A-Za-z0-9_./-]+"

(I'm unsure which special characters should be allowed though)

Andriamanitra avatar Jan 14 '24 12:01 Andriamanitra

That's not a bad idea, also would need to recognize wildcard %.o targets:

- identifier: "^[%A-Za-z0-9_./-]+"

petabyt avatar Jan 14 '24 18:01 petabyt