micro icon indicating copy to clipboard operation
micro copied to clipboard

Add syntax highlight code for ignore files

Open taconi opened this issue 1 year ago • 2 comments

Adding ignore file support by default so you don't need to install the language-ignore plugin.

image

taconi avatar Dec 28 '23 18:12 taconi

I like the idea but I would reconsider the syntax groups. The current colors seem a bit weird because files are not statements, wildcards are not identifiers, and negated files are definitely not errors.

Screenshots

Using the default config: image

Using my current config: image

Maybe using diff-added and diff-deleted colors would make more sense?

Andriamanitra avatar Jan 12 '24 23:01 Andriamanitra

[...] files are not statements, wildcards are not identifiers, and negated files are definitely not errors. Maybe using diff-added and diff-deleted colors would make more sense?

The relationship was based on colors because of the existing identifiers I did not find any related to the ignore file patterns. diff-added and diff-deleted are also not nominally related. I believe one thing that might bother you is that some color schemes add a background color to the error handler, so I don't see any problem with switching to diff-deleted.

taconi avatar Jan 14 '24 13:01 taconi

If you commit the changes from #3104 (comment) it looks good to me

@Andriamanitra Applied

taconi avatar Mar 20 '24 15:03 taconi