ngx-scanner icon indicating copy to clipboard operation
ngx-scanner copied to clipboard

ZxingScannerComponen.init method called twice when enable flag is set to true (leak once again)

Open RafalOddslife opened this issue 9 months ago • 8 comments

Hi, it's me again. I didn't notice this earlier. Issue which gives similar effect as https://github.com/zxing-js/ngx-scanner/issues/557 but now it's caused by [enable]="true" flag.

Describe the bug

ZxingScannerComponen.init method is called twice when enable flag is set to true which causes to run scanning twice (leak). onDestroy stops only one of scanning processes. Affected version: "@zxing/ngx-scanner": "^17.0.2"

Code

<button (click)="scannerVisible = !scannerVisible">Toggle scanner</button>
<zxing-scanner [enable]="true" *ngIf="scannerVisible"></zxing-scanner>

To Reproduce

Steps to reproduce the behavior:

  1. Go to simple repro
  2. Use toggle button to init and destroy zxing-scanner component (the more you do this, the bigger the leakage)
  3. Each time scanner component is initialized it's calling 'init' method twice
  4. Open chrome devtools, open Performance tab and capture new recording
  5. BrowserCodeReader is still trying to decode even after destroying component

Expected behavior Component should start only one scanning process.

Screenshots image

RafalOddslife avatar Apr 25 '24 07:04 RafalOddslife