ngx-scanner
ngx-scanner copied to clipboard
zxing-js
Can we upgrade to rxjs 7?
Current dependency is fixed to version 6. Is it possible to move to version 7?
RxJS 7 has breaking changes toward RxJS 6. @rvalitov do you see any possibility to support 6 and 7?
RxJS 7 has breaking changes toward RxJS 6. @rvalitov do you see any possibility to support 6 and 7?
If not, would you have to have a build for rxjs7? I know other repos have done this.
I just did a clone and saw that line 659 on zxing-scanner.component.ts is the only line I can see that needs updating.
if (!this.scanError.observers.some(x => Boolean(x))) {
I also found some spelling errors and translations that needed fixing. Should I push a PR? I have not updated the line yet.
PR is much appreciated! Thank you!
Great, sent up PR. I am not fully educated on RXJS so I won't be able to tackle the switch over but it looks like it should be simple if someone on your end could look at line 659!
PR is much appreciated! Thank you!
@werthdavid Are you able to fix line 659 to be compatible with RXJS 7? Would the observers become subscriber instead? Sorry I don't have too much knowledge of RXJS just yet.
Can someone have a look at https://github.com/zxing-js/ngx-scanner/pull/466