library icon indicating copy to clipboard operation
library copied to clipboard

Published 20 hours ago • verified publisher icon zxing-js

Add copyright banner to UMD variant

Open codeworrior opened this issue 3 years ago • 7 comments

When adding this library to our project (not on github, so I can't share a link, sorry), we noticed that the minified UMD variant (dist/index.min.js) only contains a copyright comment for the external ts-custom-error module, but none for your own modules. This looked a bit misleading to us.

This PR is a proposal how to address this. It uses a rollup plugin to add your LICENSE file as a banner comment to the build result. The banner is added in a way that terser doesn't remove it (/*! ... */ comment).

codeworrior avatar Apr 12 '21 06:04 codeworrior

Has this been solved in a different way?

codeworrior avatar Apr 26 '22 06:04 codeworrior

That was a mistake, sorry. I'll look into the changes you made

werthdavid avatar Apr 26 '22 06:04 werthdavid

Thanks! It's not a big thing. Just thought, the copyright comments in the UMD version should match the reality...

codeworrior avatar Apr 26 '22 06:04 codeworrior

Have you seen my comments in the code?

werthdavid avatar Apr 28 '22 05:04 werthdavid

Yes, sorry for not replying immediately - daily work, you know. I hope to be able to look into this again today or tomorrow.

Kind Regards and thanks again, Frank

codeworrior avatar Apr 28 '22 05:04 codeworrior

any updates?

werthdavid avatar Apr 19 '23 10:04 werthdavid

Stale pull request message

github-actions[bot] avatar Apr 29 '24 14:04 github-actions[bot]