flowts icon indicating copy to clipboard operation
flowts copied to clipboard

Strips comments inside types

Open nickretallack opened this issue 5 years ago • 3 comments

This issue also occurs if I just use babel-plugin-flow-to-typescript directly so I filed the issue there. Creating an issue here as well so you're aware of it.

I really appreciate your work on these conversion tools. I just ran it on a large code base and audited all the changes and now I'm filing issues about any oddities I found.

nickretallack avatar Apr 05 '20 05:04 nickretallack

will look into it, however not sure it would be easy to fix… - it is a bit tricky to preserve comments in babel transform

also btw, original babel-plugin-flow-to-typescript is not updated for a while - in flowts I am using my fork of it - https://github.com/zxbodya/babel-plugin-flow-to-typescript

zxbodya avatar Apr 05 '20 09:04 zxbodya

There's no issues tab on your fork of the babel plugin. Should I file the issues here instead then?

nickretallack avatar Apr 05 '20 19:04 nickretallack

There's no issues tab on your fork of the babel plugin. Should I file the issues here instead then?

weird, it happened to be disabled by default - enabled it

zxbodya avatar Apr 05 '20 19:04 zxbodya