zwave-js-ui
zwave-js-ui copied to clipboard
zwave-js
Asking to rebuild routes of selected nodes in the main page causes errors
Checklist
- [X] I am not using Home Assistant. Or: a developer has told me to come here.
- [X] I have checked the troubleshooting section and my problem is not described there.
- [X] I have read the changelog and my problem is not mentioned there.
Deploy method
Snap
Z-Wave JS UI version
9.8.1
ZwaveJS version
12.4.2
Describe the bug
When I select a few nodes using the checkboxes on the left of the screen, and then I ask to rebuild their routes, I get the first node selected to rebuild its routes, then I get error message on the following nodes (instantly).
I expect them to be rebuilt correctly
If I select only one at a time, it works, but when more than one is selected, only the first one works and the other ones fail immediately
To Reproduce
Main page, select a few nodes using the checkboxes on the left of the screen. Bottom right, click on the icon to open the menu for the selection, and click on "Rebuild Routes / Begin"
Expected behavior
Routes get rebuilt for all the selected nodes
Additional context
No response
@AlCalzone Did you added some checks that prevents from running concurrent rebuild routes? Because I can confirm the same on my side
I had to check. This has been like this for a while now (version 7): https://github.com/zwave-js/node-zwave-js/pull/2115
Fixing this will have to wait on https://github.com/zwave-js/node-zwave-js/issues/3707
Means very few users tried that or maybe they just didn't report this 🤷🏼♂️
@robertsLando should we remove the ability to do this from the UI for now until the underlying issue is fixed?
@AlCalzone considering the low number of reports (I think @jfhautenauven is the only one?) I would not disable it for now
i've noticed this, as well. with 30+ nodes, it was a pain to heal each of them individually after i'd tried to rebuild the routes of them all as a group. would support disabling the command until it is not harmful.
What do you mean with "harmful"? Once the first command is done, the others can be started normally. Before that they are not executed.
Maybe harm is too harsh - once the first command is done the others are left in an error state and must be run individually. This is an annoyance and unexpected. The batch command doesn't ever complete successfully.
On Thu, Jul 11, 2024 at 10:27 AM AlCalzone @.***> wrote:
What do you mean with "harmful"? Once the first command is done, the others can be started normally. Before that they are not executed.
— Reply to this email directly, view it on GitHub https://github.com/zwave-js/zwave-js-ui/issues/3559#issuecomment-2223496410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMS3MX6KG5AGX4FK45N6DODZL256PAVCNFSM6AAAAABCMLTGKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRTGQ4TMNBRGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
While I agree that this functionality should be removed, the "error state" is purely visual.
That's good to know that it doesn't dump the devices into some error state, just the UI display of the error.
On Thu, Jul 11, 2024 at 11:52 PM AlCalzone @.***> wrote:
While I agree that this functionality should be removed, the "error state" is purely visual.
— Reply to this email directly, view it on GitHub https://github.com/zwave-js/zwave-js-ui/issues/3559#issuecomment-2224940211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMS3MX77A36XBKH724UDM63ZL54JTAVCNFSM6AAAAABCMLTGKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUHE2DAMRRGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I just removed the action (just when sending to multiple nodes at once)