zwave-js-ui icon indicating copy to clipboard operation
zwave-js-ui copied to clipboard

feat: zwave-js v10

Open robertsLando opened this issue 3 years ago • 5 comments

robertsLando avatar Jul 20 '22 15:07 robertsLando

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment @zwave-js-bot fix lint

zwave-js-assistant[bot] avatar Jul 20 '22 15:07 zwave-js-assistant[bot]

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment @zwave-js-bot fix lint

zwave-js-assistant[bot] avatar Jul 22 '22 08:07 zwave-js-assistant[bot]

Pull Request Test Coverage Report for Build 2955269893

  • 1 of 90 (1.11%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 24.686%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/SocketEvents.ts 0 1 0.0%
app.ts 0 6 0.0%
lib/ZwaveClient.ts 0 82 0.0%
<!-- Total: 1 90
Totals Coverage Status
Change from base Build 2949893046: -0.06%
Covered Lines: 3688
Relevant Lines: 15782

💛 - Coveralls

coveralls avatar Jul 22 '22 13:07 coveralls

@AlCalzone I have also introduced node found event, when you add a node it should be immediatly shown in control panel as soon as it is found

robertsLando avatar Jul 25 '22 11:07 robertsLando

That seems to work, but is hard to test

AlCalzone avatar Jul 25 '22 14:07 AlCalzone