zwave-js-ui icon indicating copy to clipboard operation
zwave-js-ui copied to clipboard

[feat] Inclusion timeout should be more obvious

Open kpine opened this issue 2 years ago • 0 comments

Is your feature request related to a problem? Please describe. The inclusion dialog does not have a good indication that a timeout has occurred. It should be more obvious.

  • The countdown timer gets stuck at a non-zero time, I usually see it stop at 2 seconds
  • The flashing "spinner" at the top of the dialog continues to flash, as if something is happening
  • The dialog text says "Inclusion is started" even after it has stopped
  • The only way to exit is using the X button in the top right of the dialog

The only clues that it stopped are:

  • The "Inclusion Stopped" message is shown in the dimmed background, in the very small text area at the top
  • The "STOP" button just disappears

Both of those are very hard to notice unless you are paying close attention.

Describe the solution you'd like

  • An obvious message that the inclusion timed-out and was not successful
  • The timeout countdown to go down to zero, or just be removed when inclusion is finished
  • A button to close the dialog, such as "OK", which goes back to the initial inclusion dialog, the same as if you clicked the "STOP" button. Or just go there directly with a message that it timed out.
  • Optionally, a "RETRY" button to restart the inclusion with the same strategy, skipping the selection dialog.

Describe alternatives you've considered

Additional context

Screenshot of when the inclusion stops. It is just stuck in this state, with nothing obvious.

image

Just as a comparison, HA displays a message when it times out.

image

kpine avatar Dec 19 '21 02:12 kpine