node-zwave-js icon indicating copy to clipboard operation
node-zwave-js copied to clipboard

feat(config): support Intermatic PE653 v3.1 with water temperature reading

Open function1st opened this issue 11 months ago • 2 comments

Pull Request

Title

feat(config): support Intermatic PE653 v3.1 with water temperature reading

Description

This pull request adds support for the Intermatic PE653 device running firmware v3.1, tested using a Raspberry Pi 5 and a RaZberry 7 Z-Wave serial device. The patch updates both the config file and the command class code so that the water temperature reading is parsed correctly. In current testing, the UI label may display this measurement as "Air Temperature," but it is effectively the pool water temperature for the PE653.

Changes

  1. Updated manufacturer-proprietary command class to parse and store the water temperature from the PE653 v3.1 firmware payload.
    • @IntermaticPE653CC.ts
  2. Modified config file for manufacturer 0x0072 to define the “waterTemperature” property as a readable number.
    • @pe653.json

Testing

• Tested the modified config and command class on a device running firmware v3.1.
• Confirmed that the water temperature is read and displayed (labeled as “Air Temperature” in the UI, but functionally correct).
• Verified no regression occurs with legacy firmware or other devices.

function1st avatar Jan 12 '25 18:01 function1st

Additionally, do you have some documentation for that proprietary protocol? I wonder what else is in there.

AlCalzone avatar Jan 13 '25 09:01 AlCalzone

Because of the large amount of Z-Wave devices, we cannot write all configuration files ourselves. Help from the community is required, so we can focus our time on improving Z-Wave JS itself. 🙏🏻

This pull request has been labeled "abandoned", which means that the original author probably won't finish it. We kindly ask anyone for support who wants to help out. The next steps likely require resolving the review comments.

You can do so in your own fork, just copy the files from this PR and reference it in a new PR.

Here are a few resources for reference - don't hesitate to ask if you are having problems:

We may get around to doing it ourselves at some point, but community support will speed up this process immensely.

Thanks!

zwave-js-assistant[bot] avatar May 12 '25 08:05 zwave-js-assistant[bot]