node-zwave-js icon indicating copy to clipboard operation
node-zwave-js copied to clipboard

fix(config): correct config parameters for Minoston MP21ZD Dimmer Plug

Open rymarczy opened this issue 1 year ago • 1 comments

The existing configuration parameters for the MP21ZD were pulled from a similar, but different, Minoston dimmer plug and are mostly incorrect.

This PR corrects the configuration parameters for the MP21ZD, based on the parameters available in the user manual from Minoston: https://cdn-files.myshopline.com/file/store/1701829637050/MP21ZD(800-Series)-Manual.pdf

This required a few additions to the template config, for new parameters that appear to not have any prior work in existing template files.

I believe I followed all the style guide rules, to the best of my ability, but always open for feedback.

Thanks!

rymarczy avatar Feb 22 '24 13:02 rymarczy

I have nightmares from the mess around those Minoston devices. Will have to look at this in depth before a review.

AlCalzone avatar Apr 04 '24 17:04 AlCalzone

Thanks for the patience and the PR!

AlCalzone avatar Jun 10 '24 07:06 AlCalzone