node-zwave-js icon indicating copy to clipboard operation
node-zwave-js copied to clipboard

feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller

Open zackbcom opened this issue 1 year ago • 3 comments

Fixes #6570

Changes

Testing artifacts

  • I have tested this on the UI.
    • image
    • image

zackbcom avatar Dec 27 '23 21:12 zackbcom

@AlCalzone What is the best way to test configs on the ui?

I'm running zwave-js-ui on a docker container. Am I able to copy the configs into the container and re-integrate the device to test these changes? Do you know the location if that is the easiest way?

Thanks.

Edit: I put them into my volume mount: /store/.config-db/devices/... and got them to work.

zackbcom avatar Jan 01 '24 22:01 zackbcom

@AlCalzone ready for review

zackbcom avatar Feb 10 '24 07:02 zackbcom

Sorry for the delay - I just got back from parental leave. I'd have fixed this myself, but the comments about the defaults left me confused... What are the default values the device has when freshly reset and paired? The ones in the JSON file or the ones in the comments behind them?

Other than that I have a few minor remarks:

I have updated the default values to the one from the device firmware. The others were from the manual, which i have removed.

@AlCalzone Ready for review

zackbcom avatar Apr 11 '24 02:04 zackbcom