node-zwave-js icon indicating copy to clipboard operation
node-zwave-js copied to clipboard

switching to 16-bit node IDs is currently done twice during startup

Open AlCalzone opened this issue 2 years ago • 3 comments

... once before and once after soft-reset.

AlCalzone avatar Aug 14 '23 14:08 AlCalzone

@jtbraun did your PR https://github.com/zwave-js/node-zwave-js/pull/6401 include a fix for this too?

Hedda avatar Jan 19 '24 15:01 Hedda

Not that I wrote or know of, but @AlCalzone rearranged some things to do long-range controller capability detection better, which may have changed this behavior. You can ask them, or just check the beta.

I haven't read the specs, but I normally would assume a soft-reset would/should reset the node-id size, and that you'd expect there to be a switch back to 16-bit nodes after the reset operation. Is that not the case?

jtbraun avatar Jan 19 '24 15:01 jtbraun

All the issues linked from the PR should be fixed. But as the PR hasn't landed on the master branch yet, Github hasn't closed them.

And yes, I've reordered the initialization sequence to make a bit more sense.

AlCalzone avatar Jan 19 '24 18:01 AlCalzone

This is merged since v12.5.0

AlCalzone avatar Apr 08 '24 10:04 AlCalzone