node-zwave-js
node-zwave-js copied to clipboard
Able to perform many parallel re-interviews for battery devices
Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?
NO, my problem is NOT within Z-Wave JS UI
Checklist
-
[X] I have checked the troubleshooting section and my problem is not described there.
-
[X] I have read the changelog and my problem was not mentioned there.
Describe the bug
What causes the bug?
I can submit an "unlimited" (not sure the real number, I tried around 50) re-interview requests to a sleeping node, and all requests are honored.
What do you observe?
The driver will perform all interview steps N times in parallel for every request.
What did you expect to happen?
The driver would ignore the duplicate requests and only perform one re-interview.
Steps to reproduce the behavior:
It can be reproduced in either HA w/the integration, or zwave-js-ui, but the former is easier if you want to issue a lot of commands. Use re-interview in zwave-js-ui a few times for the same effect.
- Go to the device page in HA for a sleeping device
- Click on the '...' overflow menu
- Click re-interview
- Click "Start re-interview" as many times as desired, e.g. 50 times. Clicking on the button won't show much feedback, but it is sending the commands to the driver
- Wake up the sleeping device to being the interview
- Observe the driver is performing all N interviews at the same time
Device information
Any sleeping device presumably.
How are you using node-zwave-js
?
- [ ]
zwave-js-ui
(formerlyzwavejs2mqtt
) Docker image (latest) - [ ]
zwave-js-ui
(formerlyzwavejs2mqtt
) Docker image (dev) - [ ]
zwave-js-ui
(formerlyzwavejs2mqtt
) Docker manually built (please specify branches) - [ ]
ioBroker.zwave2
adapter (please specify version) - [X]
HomeAssistant zwave_js
integration (please specify version) - [ ]
pkg
- [ ]
node-red-contrib-zwave-js
(please specify version, double click node to find out) - [ ] Manually built from GitHub (please specify branch)
- [ ] Other (please describe)
Which branches or versions?
version:
node-zwave-js
branch: 10.2.0
zwave-js-ui
branch: 8.0.0
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
Don't know, this is a new device
If yes, where did it work?
No response
Attach Driver Logfile
yeah, I think the real number is whatever your machine can handle 🙈